Add extra data and fix resolution - #42
Merged
Merged
Conversation
TG1999
force-pushed
the
fix
branch
3 times, most recently
from
July 22, 2022 09:21
83ce6f3 to
7749189
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Contributor
Author
|
Generate requirements only from a sdist if the said package don't generate any requirements from wheels, while generating requirements from a sdist generate requirements from a requirements.txt file if nothing can't be generated from setup.cfg and setup.py and requirements.txt was used in either setup.py or setup.cfg |
Generate requirements only from a sdist if the said package don't generate any requirements from wheels, while generating requirements from a sdist generate requirements from a requirements.txt file if nothing can't be generated from setup.cfg and setup.py and requirements.txt was used in either setup.py or setup.cfg Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
commented
Jul 26, 2022
pombredanne
requested changes
Jul 27, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Here are a few minor nit pickings for your consideration.
pombredanne
reviewed
Jul 27, 2022
Merged
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
commented
Jul 28, 2022
TG1999
commented
Jul 28, 2022
TG1999
commented
Jul 28, 2022
TG1999
commented
Jul 28, 2022
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
reviewed
Jul 29, 2022
pombredanne
reviewed
Jul 29, 2022
pombredanne
reviewed
Jul 29, 2022
pombredanne
reviewed
Jul 29, 2022
pombredanne
reviewed
Jul 29, 2022
| """ | ||
| if not os.path.exists(location): | ||
| return [] | ||
| deps = list(handler.parse(location)) |
Member
There was a problem hiding this comment.
Suggested change
| deps = list(handler.parse(location)) | |
| # TODO: consider using packagedcode.recognize instead for | |
| # more generic and reusable approach | |
| deps = list(handler.parse(location)) |
pombredanne
reviewed
Jul 29, 2022
pombredanne
reviewed
Jul 29, 2022
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
|
I will let you fix the failures I have introduced... likely from formatting |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Member
|
All green... merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com